opdev / opcap

Apache License 2.0
3 stars 15 forks source link

Reorganize and format report templates and JSON #317

Closed trgeiger closed 1 year ago

trgeiger commented 2 years ago

Fixes #306

Description of PR

Moved constants from report.go into separate template files for operator and operand constants. Reformatted the JSON constants to be human-legible.

Fixes #306

Changes (required)

Checklist (required)

trgeiger commented 2 years ago

@acmenezes picked this up real quick. Let me know if this is the sort of result you were imagining when you wrote up #306.

mrhillsman commented 1 year ago

/approve

exe-prow-github-app[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bcrochet, mrhillsman, skattoju

Associated issue: #306

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opdev/opcap/blob/main/OWNERS)~~ [mrhillsman] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment