Update the finalizers on the server side

bcrochet commented 1 year ago

Description of PR

Calling SetFinalizers only sets the local object field. It does not actually update the object on the server. A call to UpdateUnstructured needed to be created in the client struct, and called after updating that field.

Fixes #343

Signed-off-by: Brad P. Crochet brad@redhat.com

Changes (required)

Update client to have UpdateUnstructured
Use UpdateUnstructured call

Checklist (required)

[X] I have reviewed and followed the contribution guidelines
[X] I have performed a self-review of my code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation if needed
[X] I have checked that my changes pass all tests

acmenezes commented 1 year ago

/approve

exe-prow-github-app[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acmenezes, acornett21, skattoju

Associated issue: #101

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opdev/opcap/blob/main/OWNERS)~~ [acmenezes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

opdev / opcap