search

opds-community / drafts

Contains all the current drafts for the OPDS specifications
36 stars 10 forks source link

Make metadata and links required for each group #36

Closed vbessonov closed 3 years ago

vbessonov commented 3 years ago

This PR makes metadata and links properties required for each group.

HadrienGardeur commented 3 years ago

I'm not so sure about links, is there any specific reason why you added them in addition to metadata?

There's no requirement for groups to include a self link for example.

vbessonov commented 3 years ago

@HadrienGardeur, the spec says the following:

An OPDS 2.0 Catalog Feed is a collection too, with the following requirements:

  • it must contain a reference to itself using a self link in links

I thought it assumed that the feed must contains links as well. But it might meant that the feed must contain a self link only if it contains links.

HadrienGardeur commented 3 years ago

A feed requires a link but that's not the case of a group.

vbessonov commented 3 years ago

You're absolutely right. I updated the PR but the name of the branch still has links in it. I can delete it and create a new if it's required.