Default values with environment variable support for fields like proxy in manifests

opea-project / GenAIInfra

Containerization and cloud native suite for OPEA

Apache License 2.0

26 stars 48 forks source link

Default values with environment variable support for fields like proxy in manifests #67

Closed mkbhanda closed 2 months ago

mkbhanda commented 4 months ago

Could we have a default value like NA or nil or null or something and environment variable support to avoid having users edit the yaml files for things like proxy?

yongfengdu commented 3 months ago

Proxy is something user/environment specific. We defined a global variable with default null, but if user wants to deploy it in an proxy environment, he still needs to edit it. https://github.com/opea-project/GenAIInfra/blob/main/helm-charts/codegen/values.yaml#L34

daisy-ycguo commented 2 months ago

I think this issue is addressed. So close it.