opea-project / GenAIInfra

Containerization and cloud native suite for OPEA
Apache License 2.0
26 stars 48 forks source link

[ChatQnA integration between GMC and OneClick] Need to remove the namespace for microservice endpoints. #77

Closed zhlsunshine closed 2 months ago

zhlsunshine commented 3 months ago

I notice that all microservice endpoints in qna_configmap_xeon.yaml and qna_configmap_gaudi.yaml contains the service's namespace default, it means that we only can deploy these microservices in default namespace. We should make user can deploy the ChatQnA demo in any namespace they like, so need to remove the namespace for microservice endpoints. Thanks!

leslieluyu commented 3 months ago

Thanks for the message! We already noticed that, need to test and confirm after remove the "default".

zhlsunshine commented 3 months ago

Hi @leslieluyu, just directly remove default may not be proper because it would lead to errors for services availability. Basically, it should be dynamical based on the deployment of microservices.
According to above description, I think it should be hard for you to aware of the microservices deployment info. We may need to discuss it, does it make sense? @KfreeZ who can co-work on this.

KfreeZ commented 3 months ago

Hi @leslieluyu, just directly remove default may not be proper because it would lead to errors for services availability. Basically, it should be dynamical based on the deployment of microservices. According to above description, I think it should be hard for you to aware of the microservices deployment info. We may need to discuss it, does it make sense? @KfreeZ who can co-work on this.

yes, if there's a wildcard symbol to represent the changing factors would be better.