opea-project / GenAIInfra

Containerization and cloud native suite for OPEA
Apache License 2.0
16 stars 22 forks source link

GMC: over write config map template before GMC resources are deployed #91

Closed KfreeZ closed 2 weeks ago

KfreeZ commented 2 weeks ago

Description

For PR details and reviews, please refer to #86

This is an duplicate PR with https://github.com/opea-project/GenAIInfra/pull/86 , in https://github.com/opea-project/GenAIInfra/pull/86 , met an issue that the coverage cannot be calculated as expected, I ran it locally the result is 70.9%, but on github work flow, the data is lower than 20%, make this new PR to test, still the same. Since this PR is blocking other work, the short workaround is to lower the coverage target, for the pr to merge, and open an issue to track the coverage problem.

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

Dependencies

n/a

Tests

refer to #86

KfreeZ commented 2 weeks ago

This is an duplicate PR with #86 , in #86 , met an issue that the coverage cannot be calculated as expected, I ran it locally the result is 70.9%, but on github work flow, the data is lower than 20%, make this new PR to test, still the same. Since this PR is blocking other work, the short workaround is to lower the coverage target, for the pr to merge, and open an issue to track the coverage problem.

KfreeZ commented 2 weeks ago

@zhlsunshine @irisdingbj Please review

KfreeZ commented 2 weeks ago

issue https://github.com/opea-project/GenAIInfra/issues/92 is created to track the code coverage problem.