opekope2 / OptiGUI

Blazing fast custom GUI textures on Fabric and Quilt with built-in OptiFine custom GUI resource pack support
https://opekope2.dev/OptiGUI/
MIT License
24 stars 9 forks source link

Quick Shulker compatibility #19

Open BossCreeper81 opened 1 year ago

BossCreeper81 commented 1 year ago

When opening Shulkerboxes in your inventory, via Quick Shulker, they have the default shulker gui colour, instead of their corresponding color. (using Colorful Containers)

https://github.com/kyrptonaught/quickshulker/issues/59#issue-1348588998

opekope2 commented 1 year ago

I took a look at the original issue, and yes, OptiGUI v1 works that way (remembers the last container). As of now, OptiGUI 2 works with entities and block entities (QuickShulker doesn't place a block entity, that's why it doesn't work out of the box), or general blocks (like loom) with fewer features. However, since OptiGUI 2 is made extensible, I have some ideas how to make these mods work together. The simplest solution would be adding some code to QuickShulker, which I can do later (this code creates filters for general shulker box UI based on the opened shulker box item. Since it's not a vanilla feature, I don't plan to add it to OptiGUI).

opekope2 commented 1 year ago

OptiGUI will have client-side QuickShulker support (2.2.0-alpha.1 and onwards). No server mod update needed. Yes, I do have a QuickShulker patch, but it will break with the current codebase (because I refactored it). This way, OptiGUI can remain client-side only, and doesn't depend on the QuickShulker dev to include a patch, and an OptiGUI update won't break QS if I change it too much. I didn't do it yet, because I found no better way to do it, than passing data from a mixin to another Which can cause funkyness with high ping or server lag.