[BUG] villager.type - Githubissues

YoungSoulluoS commented 3 months ago

Is there an existing issue for this?

[X] I have searched the existing issues

Expected Behavior

Work 8)

Actual Behavior

Not work 8)

Steps To Reproduce

Loader and its version

Fabric Loader 0.15.7 1.20.2 ( and 4)

OptiGUI version

OptiFUI 2.3.0-alpha.2

Behavior difference

[X] Behavior is different from OptiGUI documentation
[ ] Behavior is different from OptiFine
[X] Behavior is different from expected (or straight up doesn't work)

Anything else

Looks like villager.type isn't filtering properly. villaget.professions works great.

Thank you for Good Mod!

YoungSoulluoS commented 3 months ago

Looks like the problem here, the filter involves Type = plains and compares to Identifier = minecraft:plains Because Type not containt namespace

opekope2 commented 3 months ago

Uh well If AbstractListSelector<T>.transformInteraction returned T? instead of Any?, this would be a compilation error. But yes, the problem is that it loads an Identifier, which will never be equal to a VillagerType

opekope2 / OptiGUI

[BUG] villager.type #89