open-AIMS / ADRIA.jl

ADRIA: Adaptive Dynamic Reef Intervention Algorithms. A multi-criteria decision support platform for informing reef restoration and adaptation interventions.
MIT License
14 stars 5 forks source link

Improved support for spatial maps #750

Closed ConnectedSystems closed 5 months ago

ConnectedSystems commented 5 months ago
using ADRIA
using GeoMakie, GraphMakie, GeoMakie

moore_dom = ADRIA.load_domain("<path to cluster-scale domain>")
gbr_dom = ADRIA.load_domain(RMEDomain, "<path to RME dataset>", "45")

ADRIA.viz.map(moore_dom)  # See figure 1
ADRIA.viz.map(gbr_dom)  # See figure 2

Figure 1: image

Figure 2: image

I've yet to work out why the gridlines (with lat/longs) disappear for the smaller spatial scale, and why there is a relatively large space between the map and the colorbar.

Any thoughts @DanTanAtAims ?

FYI I've made the figures with the following Domain versions:

Moore_2024-02-05b_v060_rc1 and rme_ml_2024_01_08

DanTanAtAims commented 5 months ago

The grid lines for small domains are so coarse/spread out and the reef so small that the reef is displayed inbetween gridlines with the grid lines being off screen. If you zoom out enough for small plots the grid lines will appear.

DanTanAtAims commented 5 months ago

The gap between the map and the colourbar is caused by the size of the map. Other people who have run into this issue seem to find it to be a result of the aspect ratio, but this doesn't seem to be our problem. image

ConnectedSystems commented 5 months ago

Noting some things for me to try later:

ConnectedSystems commented 5 months ago

Okay, the "fix" is to define a figure size so that the auto-resizing has something to work off:

image

image

The downside is now there's extra space along the top and bottom, but it looks nicer this way.

Grid lines and missing x/y axis labels seems to be an issue with GeoMakie, so I'm leaving that as is for now.

ConnectedSystems commented 5 months ago

@DanTanAtAims see very last commit, but otherwise I think good to go if you can't see any problems.