search

open-AIMS / ADRIA.jl

ADRIA: Adaptive Dynamic Reef Intervention Algorithms. A multi-criteria decision support platform for informing reef restoration and adaptation interventions.
MIT License
14 stars 5 forks source link

Minor updates to geospatial functions/handling #798

Closed ConnectedSystems closed 2 months ago

ConnectedSystems commented 2 months ago

Some small maintenance changes.

ConnectedSystems commented 2 months ago

Found some more bugs when trying to resolve the previous issue.

Tests will still fail but for unrelated reasons (more PRs incoming to try to resolve those, but some will need input from @Zapiano).

ConnectedSystems commented 2 months ago

@Rosejoycrocker This PR will now resolve #800 , at least for ADRIA tests. The synthetic data generation will need to create geopackages with a valid CRS.

Rosejoycrocker commented 2 months ago

@Rosejoycrocker This PR will now resolve #800 , at least for ADRIA tests. The synthetic data generation will need to create geopackages with a valid CRS.

Thanks @ConnectedSystems, noted. The synthetic GeoDataframe itself has a defined CRS so I think I just need to specify this when it's saved to a geopackage

ConnectedSystems commented 2 months ago

For the record, the geopackages in this PR were updated manually by attaching CRS WGS84 (EPSG:4326) in QGIS.