search

open-AIMS / ADRIA.jl

ADRIA: Adaptive Dynamic Reef Intervention Algorithms. A multi-criteria decision support platform for informing reef restoration and adaptation interventions.
MIT License
18 stars 6 forks source link

metrics.summarize_raw trying to access non existent attribute from ResultSet #820

Open Zapiano opened 3 months ago

Zapiano commented 3 months ago

This function tries to access rs.raw, which doesn't exist. https://github.com/open-AIMS/ADRIA.jl/blob/a8dc10942c596a7231172a1d0805566b6a8d1dbb/src/metrics/temporal.jl#L53

I'm not sure if this function should be deleted or modified. I am also not sure what rs.raw is supposed to be.

ConnectedSystems commented 3 months ago

Wow, this is very old.

The run_model() interface function returns a namedtuple, in which one of the fields holds the raw results. Horrible name, but at the time I was thinking an "ecosystem model" may not be concerned only with coral cover, hence it would return the "raw" unprocessed results from a model.

Circa 2 years ago, there was a corresponding field in the Result Set, which I think we've renamed to something more appropriate like "relative cover"...

All this said, all the code in this file needs to be updated or removed. The use cases have shifted compared to two years ago. I'm thinking we can do most, if not all, the same things with the current set of scenario-based metrics