Cover conversions not working

open-AIMS / ADRIA_matlab

Repository for the development of ADRIA: Adaptive Dynamic Reef Intervention Algorithms. ADRIA is a multi-criteria decision support tool set particularly useful for informing reef restoration and adaptation interventions.

1 stars 0 forks source link

Cover conversions not working #74

Closed KRNA01 closed 2 years ago

KRNA01 commented 2 years ago

@ConnectedSystems, I have just pushed an updated conversion function that should work.

It's pushed to a new Branch SprintFixesKen and the function is baseCoralNumbersFromCoversAllTaxaUpdated(target_covers).

This is very preliminary, but should get us out of trouble for now. Let me know if anything is off.

Note that Large Massives are hard-coded with 5% start cover

ConnectedSystems commented 2 years ago

Hi @KRNA01

Should these be divide by 2, rather than multiply?

https://github.com/open-AIMS/ADRIA_repo/blob/7469f5bdb0ebdb0c468fe91e63053f8a983901f7/ADRIAfunctions/ParamHandler/baseCoralNumbersFromCoversAllTaxaUpdated.m#L46

KRNA01 commented 2 years ago

Hi @ConnectedSystems,

The conversion vectors become divisors in lines 46 and 48, so 2 becomes 0.5.

ConnectedSystems commented 2 years ago

Ah, sorry - have tunnel vision. Looks good then, I will incorporate into mine.

ConnectedSystems commented 2 years ago

Success, I think

Running for Day 2 and 3 for 2015 now.

Thanks for correcting my clumsy attempt @KRNA01