search

open-AIMS / ADRIA_matlab

Repository for the development of ADRIA: Adaptive Dynamic Reef Intervention Algorithms. ADRIA is a multi-criteria decision support tool set particularly useful for informing reef restoration and adaptation interventions.
1 stars 0 forks source link

DMCDA errors #86

Closed ConnectedSystems closed 2 years ago

ConnectedSystems commented 2 years ago

@Rosejoycrocker might be a quick easy issue to resolve but all examples and tests currently fail on main from what I suspect are recent changes from the earlier Add-absolute-connectivity-MCDA mixed with our recent changes to get delayed intervention starts into ADRIA.

Error using ADRIA_DMCDA (line 75)
Incorrect dimensions for matrix multiplication. Check that the number of columns in the first matrix matches the number of rows in the second matrix. To perform elementwise
multiplication, use '.*'.

I can take a look later if you don't have the bandwidth today.

Rosejoycrocker commented 2 years ago

Hey, I'll take a quick look now, I think I know what it might be

Rosejoycrocker commented 2 years ago

so I fixed the first issue but theres another due to 'area' not being a field in site_data - has there been a change in the structure of site_data?

ConnectedSystems commented 2 years ago

Nope - no change recently.

Are you testing with MooreReefCluster_Spatial_w4.5covers.csv?

Rosejoycrocker commented 2 years ago

Oh actually, it's the test that doesn't have it in MCDA_vars, I'll change and test again.

Rosejoycrocker commented 2 years ago

Its clearing all tests now, just pushed :)

ConnectedSystems commented 2 years ago

Thank you, Rose.

Just FYI - and I know this seems pedantic right now but it becomes more important as ADRIA matures and more people work on it - for these sort of things please submit a PR instead of merging to main directly so we can more easily track what changes relate to what issues.

ConnectedSystems commented 2 years ago

I'm seeing a strange performance regression - time taken to run a single simulation is now about double what it was before. I'll just double check a few things before closing this issue.

Rosejoycrocker commented 2 years ago

Ok sure, sorry I'll do that next time

ConnectedSystems commented 2 years ago

Issue seems to have been my laptop, it crashed during a Teams call and after two reboots simulation times have gone back down to what they were before.

Thanks @Rosejoycrocker

Closing thanks to changes in commit 74d0a5318067b17f2b7534b991584ee94e15210f and e7ee2becbdb94a8d285b404133886f7c6675841a