search

open-abap / open-abap-core

Core ABAP artifacts
MIT License
48 stars 15 forks source link

open-abap unit test breaks after transpiling #848

Closed oblomov-dev closed 7 months ago

oblomov-dev commented 7 months ago

Hi @larshp,

after transpiling to open-abap and running the unit tests i get this error: https://github.com/abap2UI5/abap2UI5/actions/runs/7928068163/job/21645588187?pr=893

image

This method is failing (also all the other unit tests of this class, but i guess they have the same root cause): https://github.com/abap2UI5/abap2UI5/blob/0287284940300a0942e5febb8390a8c50b2c1c25/src/01/02/01/z2ui5_cl_core_bind_srv.clas.testclasses.abap#L89

Refactored most of the classes and splitted them into smaller units, but all other classes & unit tests seem to work with open-abap so i can not encircle this problem closer, just these ones are failing. Any hints welcome or if there is something else i can do on my side?

larshp commented 7 months ago

reproduced in https://github.com/open-abap/open-abap-core/pull/849

something is wrong when handling DEFERRED stuff

larshp commented 7 months ago

@oblomov-dev try again, update everything to latest

oblomov-dev commented 7 months ago

https://github.com/abap2UI5/abap2UI5/pull/898

image

updated everything and used my latest code. looks very good now 🥳 Nice, thank you!