open-amdocs / webrix

Powerful building blocks for React-based web applications
https://webrix.amdocs.com
Apache License 2.0
431 stars 31 forks source link

`isClickedOutside` override (optional) condition to also fire on `mouseup` #104

Closed yairEO closed 1 year ago

yairEO commented 1 year ago

isClickedOutside frin the override context should be taken into consideration on mouseup as well because the mousedown event propagation might be prevented (more likely than the mouseup event)

codecov[bot] commented 1 year ago

Codecov Report

Base: 96.00% // Head: 96.00% // No change to project coverage :thumbsup:

Coverage data is based on head (e12d937) compared to base (8868a1e). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #104 +/- ## ======================================= Coverage 96.00% 96.00% ======================================= Files 61 61 Lines 852 852 Branches 29 29 ======================================= Hits 818 818 Misses 33 33 Partials 1 1 ``` | [Impacted Files](https://codecov.io/gh/open-amdocs/webrix/pull/104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-amdocs) | Coverage Δ | | |---|---|---| | [src/hooks/useClickOutside/useClickOutside.js](https://codecov.io/gh/open-amdocs/webrix/pull/104/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-amdocs#diff-c3JjL2hvb2tzL3VzZUNsaWNrT3V0c2lkZS91c2VDbGlja091dHNpZGUuanM=) | `80.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-amdocs). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-amdocs)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

rafmim commented 1 year ago

bypassing branch protection (codecov coverage bellow threshold) as requested (and confirmed) by @yairEO

udia76 commented 1 year ago

:tada: This PR is included in version 1.5.12 :tada:

The release is available on:

Your semantic-release bot :package::rocket: