open-amdocs / webrix

Powerful building blocks for React-based web applications
https://webrix.amdocs.com
Apache License 2.0
432 stars 32 forks source link

Improved tests & added new ones #114

Closed yairEO closed 1 year ago

yairEO commented 1 year ago

Some tests have been simplified and also have added some tests in places where coverage was not enough

codecov[bot] commented 1 year ago

Codecov Report

Base: 95.98% // Head: 98.05% // Increases project coverage by +2.07% :tada:

Coverage data is based on head (9b8fe0f) compared to base (99376b5). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 2.x #114 +/- ## ========================================== + Coverage 95.98% 98.05% +2.07% ========================================== Files 63 63 Lines 821 821 Branches 30 30 ========================================== + Hits 788 805 +17 + Misses 32 14 -18 - Partials 1 2 +1 ``` | [Impacted Files](https://codecov.io/gh/open-amdocs/webrix/pull/114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-amdocs) | Coverage Δ | | |---|---|---| | [src/tools/Puppeteer/Puppeteer.jsx](https://codecov.io/gh/open-amdocs/webrix/pull/114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-amdocs#diff-c3JjL3Rvb2xzL1B1cHBldGVlci9QdXBwZXRlZXIuanN4) | `94.73% <0.00%> (+10.52%)` | :arrow_up: | | [src/hooks/useTimeout/useTimeout.js](https://codecov.io/gh/open-amdocs/webrix/pull/114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-amdocs#diff-c3JjL2hvb2tzL3VzZVRpbWVvdXQvdXNlVGltZW91dC5qcw==) | `100.00% <0.00%> (+25.00%)` | :arrow_up: | | [src/hooks/useClickOutside/useClickOutside.js](https://codecov.io/gh/open-amdocs/webrix/pull/114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-amdocs#diff-c3JjL2hvb2tzL3VzZUNsaWNrT3V0c2lkZS91c2VDbGlja091dHNpZGUuanM=) | `100.00% <0.00%> (+33.33%)` | :arrow_up: | | [src/components/Poppable/Poppable.hooks.js](https://codecov.io/gh/open-amdocs/webrix/pull/114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-amdocs#diff-c3JjL2NvbXBvbmVudHMvUG9wcGFibGUvUG9wcGFibGUuaG9va3MuanM=) | `100.00% <0.00%> (+50.00%)` | :arrow_up: | | [src/components/Poppable/Poppable.stateful.jsx](https://codecov.io/gh/open-amdocs/webrix/pull/114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-amdocs#diff-c3JjL2NvbXBvbmVudHMvUG9wcGFibGUvUG9wcGFibGUuc3RhdGVmdWwuanN4) | `100.00% <0.00%> (+100.00%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-amdocs). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-amdocs)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.