open-amdocs / webrix

Powerful building blocks for React-based web applications
https://webrix.amdocs.com
Apache License 2.0
431 stars 31 forks source link

scrollable tracks should not inherit css from ancestors #119

Closed yairEO closed 1 year ago

yairEO commented 1 year ago

it could be that multiple Scrollable components are nested, and so, their CSS styles affect each other because of how the tracks selectors are structured:

.scrollbar.vertically-scrollable .vertical-scrollbar-track

which means nested components with the class .vertical-scrollbar-track will be affected.

This fix assumes the tracks are always direct children of a .scrollbar parent

see src/components/Scrollable/components/_tracks.scss

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (b4e2c3a) 96.01% compared to head (0ebe9ea) 96.01%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #119 +/- ## ======================================= Coverage 96.01% 96.01% ======================================= Files 61 61 Lines 853 853 Branches 29 29 ======================================= Hits 819 819 Misses 33 33 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.