davidyush commented 3 years ago

The issue is in our DropDown, it has Poppable and Scrollable inside. The behavior we have is on clicking on Poppable it closes the component, so if we need to keep it opened we use stopPropagation for example list of checkboxes, regarding Scrollable it works well if to use mouse wheel, but on dragging Thumb by mouse button it makes click inside of Poppable and closes the component.

codecov[bot] commented 3 years ago

Codecov Report

Merging #67 (542cadb) into master (41c5f36) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   95.38%   95.39%   +0.01%     
==========================================
  Files          61       61              
  Lines         845      847       +2     
  Branches       27       27              
==========================================
+ Hits          806      808       +2     
  Misses         33       33              
  Partials        6        6

Impacted Files	Coverage Δ
...onents/HorizontalScrollbar/HorizontalScrollbar.jsx	`93.33% <100.00%> (+0.47%)`	:arrow_up:
...components/VerticalScrollbar/VerticalScrollbar.jsx	`93.33% <100.00%> (+0.47%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 41c5f36...542cadb. Read the comment docs.

udia76 commented 3 years ago

:tada: This PR is included in version 1.5.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

open-amdocs / webrix

Scrollable - stop propagation on click thumb #67

Codecov Report