search

open-amdocs / webrix

Powerful building blocks for React-based web applications
https://webrix.amdocs.com
Apache License 2.0
431 stars 31 forks source link

pref( #56) - Use an internal ref to eliminate the need for useMemo() #85

Closed gaeaehrlich closed 2 years ago

gaeaehrlich commented 2 years ago

Fixes https://github.com/open-amdocs/webrix/issues/56

codecov[bot] commented 2 years ago

Codecov Report

Merging #85 (9f5a12c) into 2.x (6f612b7) will increase coverage by 0.01%. The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x      #85      +/-   ##
==========================================
+ Coverage   96.00%   96.02%   +0.01%     
==========================================
  Files          61       61              
  Lines         852      856       +4     
  Branches       29       29              
==========================================
+ Hits          818      822       +4     
  Misses         33       33              
  Partials        1        1
Impacted Files Coverage Δ
src/components/Movable/Movable.hooks.js 90.90% <80.00%> (+2.02%) :arrow_up:
src/components/Resizable/Resizable.hooks.js 90.90% <80.00%> (+2.02%) :arrow_up:
...onents/HorizontalScrollbar/HorizontalScrollbar.jsx 100.00% <100.00%> (ø)
...components/VerticalScrollbar/VerticalScrollbar.jsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6f612b7...9f5a12c. Read the comment docs.

yairEO commented 2 years ago

@gaeaehrlich check the tests, maybe something is off because it says here:

83.33% of diff hit (target 96.00%)

yairEO commented 2 years ago

@gaeaehrlich - Can you please make sure these lines of code are covered with tests?

image

image