yairEO commented 2 years ago

clientWidth & clientHeight should be taken into consideration when checking for changes in updateScrollbars.

This PR is a result of a bug I've seen in some situations, when the clientHeight changed in an editable (multiline) text box, when content is added/removed, and the scrollbar appears when it shouldn't have.

codecov[bot] commented 2 years ago

Codecov Report

Merging #98 (7917f5f) into master (6f612b7) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files          61       61           
  Lines         852      852           
  Branches       29       29           
=======================================
  Hits          818      818           
  Misses         33       33           
  Partials        1        1

Impacted Files	Coverage Δ
src/components/Scrollable/Scrollable.jsx	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6f612b7...7917f5f. Read the comment docs.

udia76 commented 2 years ago

:tada: This PR is included in version 1.5.11 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

open-amdocs / webrix

Scrollable - Improved change detection #98

Codecov Report