search

open-api-spex / open_api_spex

Open API Specifications for Elixir Plug applications
Mozilla Public License 2.0
706 stars 183 forks source link

Fix typo. #635

Closed loguntsov closed 3 weeks ago

loguntsov commented 3 weeks ago

I found this typo because my code doesn't work with valid OpenApi file.

10:56:08.878 pid=<0.3186.0> module=Df.Diagram.Component.Config line=95 [warning] ** (FunctionClauseError) no function clause matching in anonymous fn/1 in OpenApiSpex.OpenApi.Decode.add_extensions/2
    (open_api_spex 3.19.1) lib/open_api_spex/open_api/decode.ex:466: anonymous fn(%{"description" => "production", "url" => "https://trexity.app/storage"}) in OpenApiSpex.OpenApi.Decode.add_extensions/2
    (elixir 1.17.2) lib/enum.ex:4301: Enum.filter_list/2
    (open_api_spex 3.19.1) lib/open_api_spex/open_api/decode.ex:466: OpenApiSpex.OpenApi.Decode.add_extensions/2
    (elixir 1.17.2) lib/map.ex:916: Map.update!/3
    (open_api_spex 3.19.1) lib/open_api_spex/open_api/decode.ex:295: OpenApiSpex.OpenApi.Decode.to_struct/2
    (elixir 1.17.2) lib/map.ex:916: Map.update!/3
    (open_api_spex 3.19.1) lib/open_api_spex/open_api/decode.ex:403: OpenApiSpex.OpenApi.Decode.to_struct/2
    (open_api_spex 3.19.1) lib/open_api_spex/open_api/decode.ex:418: anonymous fn/1 in OpenApiSpex.OpenApi.Decode.to_struct/2
    (elixir 1.17.2) lib/map.ex:257: Map.do_map/2
    (elixir 1.17.2) lib/map.ex:257: Map.do_map/2
    (elixir 1.17.2) lib/map.ex:251: Map.new_from_map/2
    (elixir 1.17.2) lib/map.ex:916: Map.update!/3
    (open_api_spex 3.19.1) lib/open_api_spex/open_api/decode.ex:39: OpenApiSpex.OpenApi.Decode.decode/1
zorbash commented 3 weeks ago

Hi @loguntsov thanks for reporting this. Would it be possible to provide an OAS to reproduce the issue or add a test?

loguntsov commented 3 weeks ago

@zorbash actually it was this file: https://github.com/trexitycode/openapi/blob/main/dist/v1.json#L3295 the line similar on 3295 caused crash.

zorbash commented 3 weeks ago

Thanks @loguntsov