issues with the new 2D advection-diffusion example

[slayoo]

@pawelmagnu, here's an update on the post-merge status for #427:

• [x] animation is not properly uploaded to "tip" release (file not found error in the logs) - this blocks upload to PyPI
• [x] when executing on mybinder.org, there is "ModuleNotFoundError: No module named 'imageio'" error
• [x] Colab badge in the notebook has wrong URL
• [x] there is no link/badge in the examples/README.md leading to the new examples
• [x] figures in the notebook are not displayed when viewed on GitHub - there are just blank white panels
• [x] no "view on github" badge in the notebook
• [x] some header comment with a hint on what is being computed in the notebook would be very helpful

Let's aim at fixing it next week

[pawelmagnu]

@Kojec1 could you check which points have already been addressed in #456 ?

[Kojec1]

There's still an issue with the figures displayed on GitHub, missing header information and I haven't managed to check if the .gif file is successfully uploaded to the "tip" release. The other issues seem to be solve.

[pawelmagnu]

I'm pretty sure we can't check if the .gif file uploads before actually merging to main.

[slayoo]

.gif file upload works! The notebook does not work on Colab yet as it fails on first line with: This is due to lack of pip install ... commands for Colab in an initial notebook cell, like we do in other notebooks. Here's a PR addressing it: https://github.com/open-atmos/PyMPDATA/pull/458

[slayoo]

Just tested both on Colab and mybinder.org, and everything works! So, we're still missing two things:

• [x] figures in the notebook are not displayed when viewed on GitHub - notebook was committed with cell output cleared
• [x] some header comment with a hint on what is being computed in the notebook would be very helpful

[pawelmagnu]

addressed in #462

[slayoo]

kudos!