search

open-atmos / PySDM

Pythonic particle-based (super-droplet) warm-rain/aqueous-chemistry cloud microphysics package with box, parcel & 1D/2D prescribed-flow examples in Python, Julia and Matlab
https://open-atmos.github.io/PySDM/
GNU General Public License v3.0
52 stars 28 forks source link

__isub__ implementation is missing scalar option #1100

Open TomMelt opened 11 months ago

TomMelt commented 11 months ago

https://github.com/open-atmos/PySDM/blob/64a54694dad9ee4d817498ec1fc845716ea184cc/PySDM/backends/impl_numba/storage.py#L60-L69

__isub__ is missing scalar implementation (compare with __iadd__ above)

slayoo commented 11 months ago

Thank you for reporting! Looking at the code of #994 (https://github.com/open-atmos/PySDM/pull/994/files#diff-1ce57f6f2790d1c694b3db8a425ab89c421aeedfe62adfe5df3efd4c18fe09c6R65), this seems to be likely addressed there. Help welcome in reviewing and making #994 mergeable

github-actions[bot] commented 9 months ago

Stale issue message

github-actions[bot] commented 5 months ago

Stale issue message