search

open-austin / open-data-progress-report

http://open-austin.github.io/open-data-progress-report/
7 stars 14 forks source link

Refactor & design #8

Closed luqmaan closed 9 years ago

luqmaan commented 9 years ago

Refactor main.js and add some more stylings.

You can see what this looks like at luqmaan.com/open-data-progress-report.

Its also usable on mobile.

image

We can probably port these changes into the alt layout without too much difficulty.

I think the alt layout is better, I just saw it too late after starting this.

haileypate commented 9 years ago

Wow, love this so far as I'm seeing it on my iPhone! I especially like how it tells me how long ago the dataset was uploaded. If that was there before... my humble apologies for not noticing sooner ;)

Mateo, I defer executive decisions on pull requests to you. Luqmaan, dang you design too?! I feel like this style gets us closer to 'gelling' with both Open Austin's brand and COA's current site theme. Yay!

luqmaan commented 9 years ago

Heh, nvm the works on mobile part. Looks horrible on my phone.

haileypate commented 9 years ago

Hrm. Well maybe it just looks good on my big giant iPhone 6plus :D

mateoclarke commented 9 years ago

@luqmaan, Thanks for adding some :green_heart:.

I think we've decided to roll with the stacked layout. Did you check that one out? Would it be too much to ask for you to update the Handlebars template and make any necessary changes to alt.js?

Or... I can go ahead and merge these changes for index.html and main.js and learn from what you did here to implement those changes to alt-version.html and alt.js.

You're call...

luqmaan commented 9 years ago

You should learn!

mateoclarke commented 9 years ago

:+1:

mateoclarke commented 9 years ago

cool if I hold off on deploying changes to master until then?

luqmaan commented 9 years ago

Si