search

open-austin / voteatx-app

Voting place finder application for Travis County, TX
http://voteatx.us/
Other
4 stars 2 forks source link

cache regions #15

Open courtney-rosenthal opened 9 years ago

courtney-rosenthal commented 9 years ago

Each time a region is displayed, a query is issued. Some amount of caching would reduce the number of queries required.

There may be region information in the original voting place response. It should be saved for later use.

When a query is made for a region, it should be saved for subsequent use.

At least the most recent region queries should be cached. We could cache more, but need to balance off against memory consumption.

avickers commented 9 years ago

Maybe. I've yet to hear a use case where we would expect ordinary users to care about the region overlays, other than maybe clicking on checkboxes because we've made the buttons so incredibly prominent. At which point, it seems like the vast majority of them will go, "Oh, that's neat" and then probably ignore the feature--or toggle it a whole bunch of times because they like the pretty colors. It's not useful information, except in very special circumstances.

Why are the overlays even in the app? Who wants them, and what is the justification? The confusion about the info bar being clickable wouldn't be an issue if nothing on the bar was clickable because we weren't using overlays. Another usability point is that the disabled checkboxes won't be obviously disabled on tablet/mobile where the hover disabled won't display.

It seems like we're just slowing things down and using extra bandwidth for a feature looking for a use.

Two questions: How do overlays help User to vote? What actionable information do overlays convey to User?

If neither of those questions has a good answer, they should be removed, resolving several issues: UI complexity/usability and performance/bandwidth (re:mobile loading speed comment from city).

avickers commented 9 years ago

I have moved the region overlay code into a file in the frozen folder, since it is quite likely to be useful in different apps targeted at solving different user stories (higher level decision makers). As it does not directly address the needs of users of this app (voters), overlays have been removed for better performance and UI.

courtney-rosenthal commented 9 years ago

This functionality needs to be in the app. Can you please reverse this commit?

avickers commented 9 years ago

I'm a volunteer. I've been treated more like an employee. This hasn't been a collaboration. There was no clear design doc about what was wanted. Most of my ideas and preferences have been overruled, and when I've asked for explanations about some of the things I have been told to work on--they haven't been forthcoming.

So, my answer is: No. Not without a satisfactory explanation. You're on your own from this point forward, unless this becomes an actual collaboration and I get treated like a full stakeholder in the project.

avickers commented 9 years ago

Done. It may be worth testing performance after loading several city council districts on lower end mobile devices.