search

open-campaign-logger / generator-library

This repository contains the generator library files for https://campaign-logger.com/generator which can be referenced like this: "{lib:adjColor}".
Apache License 2.0
31 stars 13 forks source link

Proposed ordering for table entries #2

Open evesala opened 7 years ago

evesala commented 7 years ago

Currently the JSON table items are sorted mostly in alphabetical order.

It could be useful to order the entries from "minor" to "major" - i.e. so that treasure tables, for example, would have the most common items first, and the most rare and valuable items last.

This way it would be possible at a later stage to add modifiers to table "rolls". A modifier of, say, +10 would weigh the rarer end of the table and ensure that none of the cheapest trinkets would be generated. And vice versa for negative modifiers. (Minimum and maximum values should of course be capped to the lowest and highest values of the table, respectively.)

Even though that functionality is not yet available, the tables would already be ready for that functionality, if/whenever it will be available.

Would this be a sensible approach?

JochenLinnemann commented 7 years ago

The original tables were created by a third person. I don't recall why the entries are sorted that way. I like the idea of being able to apply mods to rolls on tables. This would extent the versatility of the generator nicely!

AvidDM commented 7 years ago

Great idea @evesala We could post guidelines/tips to file creators so they do more of this in the future. We might also ask the community for help editing files to a certain standard.

Is there a way to create a Healing category @JochenLinnemann on GitHub? Branch files to there with comments about what we'd like to see changed?

JochenLinnemann commented 7 years ago

We could just create a Healing branch, add a markdown file of tasks and files, and let the work begin.

evesala commented 7 years ago

I have added some of my tables to a separate branch. Is it OK for me to add improvement suggestions to the standard tables there?

When I'm happy with the updates, I could then ask you to check the changes so that they could be merged back to trunk.

JochenLinnemann commented 7 years ago

Go for it!

evesala commented 7 years ago

Thanks! I have been a bit cautious about this, as I'm not familiar with your practices, but just let me know when I err.