open-ce / pytorch-feedstock

Apache License 2.0
5 stars 11 forks source link

fix test_constants_with_final #29

Closed cdeepali closed 3 years ago

cdeepali commented 3 years ago

Checklist before submitting

Description

The tests - test_jit_fuser_te is using typing_extension for py38, so am seeing following test failure with py38:

  File "test_jit_fuser_te.py", line 28, in <module>
    from test_jit import backward_graph, all_backward_graphs, get_lstm_inputs, get_milstm_inputs, \
  File "/home/builder/pytorch/test/test_jit.py", line 8, in <module>
    from jit.test_recursive_script import TestRecursiveScript  # noqa: F401
  File "/home/builder/pytorch/test/jit/test_recursive_script.py", line 5, in <module>
    import typing_extensions
ModuleNotFoundError: No module named 'typing_extensions'
Traceback (most recent call last):
  File "test/run_test.py", line 745, in <module>
    main()
  File "test/run_test.py", line 728, in main
    raise RuntimeError(err_message)
RuntimeError: test_jit_fuser_te failed!

Review process to land

  1. All tests and other checks must succeed.
  2. At least one maintainer must review and approve.
  3. If any maintainer requests changes, they must be addressed.