search

open-ce / pytorch-feedstock

Apache License 2.0
5 stars 11 forks source link

refresh to v1.9.0 #70

Closed cdeepali closed 3 years ago

cdeepali commented 3 years ago

Checklist before submitting

Description

Fixes # (issue).

Review process to land

  1. All tests and other checks must succeed.
  2. At least one maintainer must review and approve.
  3. If any maintainer requests changes, they must be addressed.
jayfurmanek commented 3 years ago

I assume the fail here is just because we've not merged https://github.com/open-ce/open-ce/pull/500 yet? Any other changes needed?

jayfurmanek commented 3 years ago

requires: https://github.com/open-ce/open-ce/pull/500/

cdeepali commented 3 years ago

Yes the tests failed because open-ce/open-ce#500 is required.

However, I have also removed libgcc-ng/libstdcxx pins here, so we would need to have open-ce PR updated with GCC 7.5 for x86 as well.

cdeepali commented 3 years ago

The changes for GCC 7.5 are available in Nishidha's PR - https://github.com/open-ce/open-ce/pull/501/.