search

open-ce / pytorch-feedstock

Apache License 2.0
5 stars 11 forks source link

Contribute patches upstream? #95

Closed adamjstewart closed 2 years ago

adamjstewart commented 2 years ago

I'm curious if anyone has ever tried to contribute the PyTorch patches in this repo upstream. We use these same patches in Spack and just had to update the recipe for PyTorch 1.12. Would be great if these patches were no longer needed in 1.13.

@nicholas-sly

cdeepali commented 2 years ago

@adamjstewart, yes we do contribute to PyTorch repo with some of our fixes. However, some of these patches are specific to our build environment so we continue to use them in the recipe.

In case of PyTorch v1.12 we have one patch https://github.com/open-ce/pytorch-feedstock/blob/main/pytorch-1.12/recipe/0302-cpp-extension.patch which can be up-streamed. However we have not yet raised a PR for that.

adamjstewart commented 2 years ago

Makes sense, I think that's the only remaining patch we're using for PyTorch 1.12. Thanks for writing these patches btw!