open-city / councilmatic

DEPRECATED, replaced by https://github.com/datamade/chi-councilmatic
16 stars 9 forks source link

philly sponsors showing up in database tied to Chicago legislation #22

Closed derekeder closed 11 years ago

derekeder commented 11 years ago

Not sure how it got in here, but

http://councilmatic.opencityapps.org/legislation/836013

derekeder commented 11 years ago

this looks to be the culprit: https://github.com/open-city/councilmatic/blob/master/councilmatic/phillyleg/migrations/0025_set_headshots_on_council_members.py

@mjumbewu, any suggestions how best to handle removing this? I'm handling Chicago's via a separate SQL script: https://github.com/open-city/councilmatic/blob/master/ci/chicago_aldermen_photos.sql

mjumbewu commented 11 years ago

Ah, you're right that shouldn't be in there. It was a convenience thing for me, I suppose. I would say the migration should be deleted, but that'll probably just cause headaches. I'll empty it out though (just have the forwards and backwards methods pass).

I think the actual culprit though is https://github.com/open-city/councilmatic/blob/master/councilmatic/phillyleg/fixtures/initial_data.json . This data gets loaded every time syncdb gets run. It shouldn't be there either. What should really happen (I think) is there should be a command for loading councilmembers from a CSV file or something.

Actually, a while back I wrote an app for populating a model from a CSV file through the Django admin: https://github.com/openplans/streetscore/tree/master/street_score/bulkadmin . I'll pull that in.

derekeder commented 11 years ago

@mjumbewu awesome! its probably a good time to set some patterns up for how to store city-specific files like these (and about.html + style stuff)