search

open-city / water

Projects for the water team
3 stars 2 forks source link

Cso forecasting #12

Closed sebhtml closed 3 years ago

sebhtml commented 9 years ago

@zscore Hi Zane, here are my small changes that I made tonight to make the script work.

zscore commented 9 years ago

Hey I finally looked at this. (Sorry for the delay).

My only comment is that I think there's good canonical way to do (relative) paths in R. I'll look this up because it's something I should know anyway. Or if anyone else has a good argument about why we should manage our directory structure a different way, I'd listen to that.

-Zane

On Tue, Jan 27, 2015 at 8:59 PM, Sébastien Boisvert < notifications@github.com> wrote:

@zscore https://github.com/zscore Hi Zane, here are my small changes that I made tonight to make the script work.

— Reply to this email directly or view it on GitHub https://github.com/open-city/water/pull/12#issuecomment-71773134.

sebhtml commented 9 years ago

regarding absolute paths versus relative paths, I think VFS paths starting with a '/' are absolute. Any other path is relative (./path/to/foo or path/to/foo or ../path2/path/to/foo)

zscore commented 9 years ago

R gets its environment from where it's called, so that is a decision we should make for the project.

On Sun, Feb 1, 2015 at 8:54 PM, Sébastien Boisvert <notifications@github.com

wrote:

regarding absolute paths versus relative paths, I think VFS paths starting with a '/' are absolute. Any other path is relative (./path/to/foo or path/to/foo or ../path2/path/to/foo)

— Reply to this email directly or view it on GitHub https://github.com/open-city/water/pull/12#issuecomment-72400474.

sebhtml commented 3 years ago

Thank you !