search

open-classifieds / OpenClassifieds

OLD REPO! DO not clone/Download. Only here for historical reasons. Version 1.X
https://yclas.com
12 stars 7 forks source link

Comments not working with kamaleon theme #16

Open helhamma opened 11 years ago

helhamma commented 11 years ago

Hi,

I can't make disqus comments working with Kamaleon theme while it works fine with wpclassifieds theme for example... is there anything to do to fix it ?

Software version: v1.8.3

Link to your site/problem: http://marcel.net84.net/PRO_OC_183_customized/content/item.php?item=1&type=offer&category=tv&title=panasonic-p42v10

What steps will reproduce the problem?

  1. select Kamaleon theme (admin/settings.php, look & feel section)
  2. enter your disqus account name in comments field (admin/settings.php, external tools section)
  3. save settings
  4. display any ad from your website

What is the expected output? a comments section should be displayed at bottom page

What do you see instead? no comment section (a strange "comments " hyperlink is displayed under Ad location)

neo22s commented 11 years ago

I tihnk is better you use our pro forum for such problem.

regards

helhamma commented 11 years ago

Hi neo22s,

Could you give me is pro forum url please?

Thanks!

neo22s commented 11 years ago

It's an email address we sent to you when you bought the pro version...check the email we sent to you with the download link.

regards

emanwebdev commented 11 years ago

I improved the discus inclusion in previous version already (basically the ability to include options and customizations)

but I don't have this Kamaleon theme to test with it

neo22s commented 11 years ago

Should work on any theme anyway, I could send to you all the pro themes, but they cant be included in the repo as you may understand. regards!

emanwebdev commented 11 years ago

Hola I improved the discus but needs to rewrite a bit the templates

This is due to the lack of an abstraction layer in OC

There are unfortunately no "helpers" or GUI primitives and it's why ALL the themes need to be rewritten ....

emanwebdev commented 11 years ago

I could send to you all the pro themes, but they cant be included in the repo as you may understand

I just see you offer a new "Lite" package I don't have a website running OC so far but when I'm finished merging my new version with your new version, I will run with v. 1.8.4+

neo22s commented 11 years ago

I know of these issues that's why I started with https://github.com/neo22s/openclassifieds2

But not much free time left...sadly...

emanwebdev commented 11 years ago

unless we write a v.2.0 ? with Autoloading Classes

emanwebdev commented 11 years ago

oooppps.. :) funny. same thought @ same time.....

emanwebdev commented 11 years ago

I started with https://github.com/neo22s/openclassifieds2

can download to try?

neo22s commented 11 years ago

of course!

it's just that is a bit out of dated, the kohana version is not the newest either the twitter boostrap, and many things to do.

I started it 1 year a go: https://www.pivotaltracker.com/projects/331093#

regards

neo22s commented 11 years ago

december 2011 I started. we can talk about it if you are interested of course!

emanwebdev commented 11 years ago

I started with https://github.com/neo22s/openclassifieds2

Oh. MVC. Kohanna. i see you already defined routes aso Only memcache all Views to do

emanwebdev commented 11 years ago

december 2011 I started. we can talk about it if you are interested of course!

Are you in Spain??? (it's half an hour past midnight now here in Switzerland)

or in Brazil or elsewhere???

I cannot speak now, too late to make noise, but yes, let's Skype during daytime

emanwebdev commented 11 years ago

I will buy your "Lite" package now to test and really start with responsive templates

emanwebdev commented 11 years ago

I started with https://github.com/neo22s/openclassifieds2

you say 2011, but one can read "7 days ago" on GitHub maybe when you created that repo??

neo22s commented 11 years ago

I am today at SFO, but tuesday at Barcelona.

Don't buy the lite, I can send it to you for free for sure. Just do not share it :)

I created the repo few days a go from SVN to GIT since people seems to like it more...

emanwebdev commented 11 years ago

I created the repo few days a go from SVN to GIT since people seems to like it more...

right. U know, GitHub has been written by Linus Torvalds himself for the Linux kernel development. He wanted something very open, "social" and very fast

right now (5 AM...) playing with GitGUI I merged my version 1.8.2 (fixed some bugs + improvements) with the new 1.8.3

emanwebdev commented 11 years ago

But I still have to finish the merge of 1.7.7+ with your new 1.8.3

And it's a BIG task....

neo22s commented 11 years ago

man! go to sleep! hehe

Please detail as much as possible the changes so would be easier to review.

Thanks for the job!

emanwebdev commented 11 years ago

Right, You have a pretty detailed changelog. with the list of modified files.

I will keep such a list from now. I agree it's important and fair/clean

Right. Gotta sleep

Thanks Chema. L8ter