search

open-cli-tools / concurrently

Run commands concurrently. Like `npm run watch-js & npm run watch-less` but better.
https://www.npmjs.com/package/concurrently
MIT License
7.01k stars 228 forks source link

Switch to pnpm #354

Closed paescuj closed 1 year ago

paescuj commented 2 years ago

pnpm feels like a great alternative to npm!

~The only downside is that we could probably no longer use np (https://github.com/sindresorhus/np/issues/251) but I'd suggest to automate the release process with a GitHub workflow, anyway.~

~To be merged after #342 (will update the pull request to use pnpm v7 then)~

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 99.45% when pulling db48957c9e2a73ffcaff2f0b2d97b767b550ebb9 on paescuj:pnpm into ed3c18f7849c73df552f6b67fe4e68d030aa1bb1 on open-cli-tools:main.

paescuj commented 1 year ago

LGTM I think, is there anything still pending here? 😄

Only the open conversation... I'm going to rebase and merge it afterwards 🚀

gustavohenke commented 1 year ago

🤔 it seems pnpm is a pickier than npm when running publish:

$ pnpm publish
 ERR_PNPM_GIT_NOT_UNCLEAN  Unclean working tree. Commit or stash changes first.

If you want to disable Git checks on publish, set the "git-checks" setting to "false", or run again with "--no-git-checks".

$ git status
On branch main
Your branch is up to date with 'origin/main'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
    tst-npm/

nothing added to commit but untracked files present (use "git add" to track)

(though I might be on a possibly old release of pnpm, and this might have been a bug)

paescuj commented 1 year ago

🤔 it seems pnpm is a pickier than npm when running publish:

$ pnpm publish
 ERR_PNPM_GIT_NOT_UNCLEAN  Unclean working tree. Commit or stash changes first.

If you want to disable Git checks on publish, set the "git-checks" setting to "false", or run again with "--no-git-checks".

$ git status
On branch main
Your branch is up to date with 'origin/main'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
  tst-npm/

nothing added to commit but untracked files present (use "git add" to track)

(though I might be on a possibly old release of pnpm, and this might have been a bug)

Hmm you mean because it's not really "unclean" since it's only an untracked file? In that case it might indeed be a bit pickier and also this might have been addressed in a newer pnpm release...