search

open-cli-tools / concurrently

Run commands concurrently. Like `npm run watch-js & npm run watch-less` but better.
https://www.npmjs.com/package/concurrently
MIT License
7.11k stars 231 forks source link

Correctly quote passthrough arguments #355

Closed paescuj closed 1 year ago

paescuj commented 2 years ago

Correctly quote passthrough arguments by switching from shell-quote to escape-it.

Addresses https://github.com/open-cli-tools/concurrently/pull/307#issuecomment-1139086865.

This is required since the arguments needs to be quoted / escaped differently depending on the platform, something which is not supported by shell-quote. Additionally, shell-quote seems to escape unnecessary things.

Potential breaking change, in a positive meaning since it was not working correctly before (for example in case of the referenced comment)!

Note: Unfortunately, escape-it doesn't seem to be maintained anymore, so we might want to either include this directly in concurrently or create an own external module...

ToDo:

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling b651051a44e61211a1882f26a393896e28dfa7f7 on paescuj:enhance-passthrough-args into 72ae69ed85141339f2d452dcdbfa5c1d4825b5e0 on open-cli-tools:main.