search

open-cli-tools / concurrently

Run commands concurrently. Like `npm run watch-js & npm run watch-less` but better.
https://www.npmjs.com/package/concurrently
MIT License
7k stars 228 forks source link

Inconsistent exit codes across OSes #405

Closed 40x closed 1 year ago

40x commented 1 year ago

I am using the package to run my integration tests. It does two things

  1. start the webpack dev server
  2. run the jest tests against it

Tests run successfully and exit with 0, that in turn triggers the SIGTERM being sent to other processes (as shown in the logs) but the exit code sent to the process on windows is 1 while it is SIGTERM on mac.

We rely on SIGTERM to do some clean-up but because of the way it exits right now, we are unable to do so only on windows.

On Windows -

image

On Mac - image

gustavohenke commented 1 year ago

Well, yeah. Windows doesn't have signals AFAIK