search

open-cli-tools / concurrently

Run commands concurrently. Like `npm run watch-js & npm run watch-less` but better.
https://www.npmjs.com/package/concurrently
MIT License
7k stars 228 forks source link

Allow setting `raw` per command when using the API #411

Closed chbiel closed 1 year ago

chbiel commented 1 year ago

In our setup, one of the processes is a docker compose process. For this process we want to have raw output, but for other processes we would still like to have prefixes and colors.

I also removed one unused property. If you don't want that I can also take that commit out.

Thanks in advance

chbiel commented 1 year ago

I see the failing tests, but it's unclear for me, how this could be related to my changes. Do you have an idea?

paescuj commented 1 year ago

Thanks for your contribution ❤️

I see the failing tests, but it's unclear for me, how this could be related to my changes. Do you have an idea?

Seems to be just a timing issue, unfortunately happens sometimes (not related to your changes).

coveralls commented 1 year ago

Coverage Status

Coverage: 99.499% (+0.02%) from 99.483% when pulling 56ab79851296213cadf0281164fdacbf26d38da7 on chbiel:main into 23c32179c7c6b97d3872880d55a8218180bbda2e on open-cli-tools:main.

chbiel commented 1 year ago

hi @paescuj, do you have an idea when the PR can be merged?

paescuj commented 1 year ago

Will try to review this evening 👍

chbiel commented 1 year ago

I also removed one unused property. If you don't want that I can also take that commit out.

Why do you think it's unused? At least it's documented here: https://github.com/open-cli-tools/concurrently#closeevent

Yes and it is still a valid parameter as part of the CommandInfo type, but there is no usage with the Command class (no read or write). So setting the cwd property or not on the Command type does not do any difference. The cwd configuration is only used as part of the SpawnOptions and gets still applied.

chbiel commented 1 year ago

hey @paescuj, any updates here? As said I did not remove the cwd completely, but only from the Command class were it is not used. I think it is still a valid change.

The other changes I applied