Can't kill any processes when --raw is passed

open-cli-tools / concurrently

Run commands concurrently. Like `npm run watch-js & npm run watch-less` but better.

https://www.npmjs.com/package/concurrently

MIT License

7k stars 228 forks source link

Can't kill any processes when --raw is passed #415

Open aminomancer opened 1 year ago

aminomancer commented 1 year ago

Description: With concurrently -r -k npm:parcel:dev npm:serve I can't exit with any kind of input, but the same without -r works fine with e.g. Ctrl+C.
Expected Behavior: I wouldn't expect the --raw argument, which ostensibly just affects printing, to affect what my inputs are able to do.
Environment: concurrently 8.0.1 on Windows 10. reproduced with powershell and cmd.exe, also in windows terminal and VS Code's integrated terminal.
Reproduction: Try the command above, where parcel is any parcel command and serve is e.g. nodemon

Thanks!

gustavohenke commented 1 year ago

Thanks for the details.

I can't reproduce it on macOS, but I did notice that parcel is possibly intercepting stdin. As in, it has a ~1s delay before accepting the Ctrl+C, whereas nodemon (or whatever other command) by itself accepts the Ctrl+C immediately.

@paescuj do you still have a Windows VM handy to test this?

the --raw argument, which ostensibly just affects printing, to affect what my inputs are able to do.

--raw passes stdio: 'inherit' to spawned commands, therefore this issue happening isn't so surprising actually.

olyop commented 1 year ago

I know it's outside of the JS ecosystem but I had the same problem when running Java gradle build. It seems it's the only process in the list that holds it up too.