open-cli-tools / concurrently

Run commands concurrently. Like `npm run watch-js & npm run watch-less` but better.
https://www.npmjs.com/package/concurrently
MIT License
6.98k stars 227 forks source link

Deprecation warning with Node 22 #477

Closed Urmeli0815 closed 3 months ago

Urmeli0815 commented 3 months ago

After upgrading to Node 22 we get a deprecation warning DEP0060 caused by the dependency spawn-command:

at module.exports (...\node_modules\spawn-command\lib\spawn-command.js:9)
at Proxy.start (...\node_modules\concurrently\dist\src\command.js:55:28)
...

The code that causes that is this line

The fix looks trivial but spawn-command doesn't seem to be developed anymore. Maybe the functionality could be integrated in concurrently.

gustavohenke commented 3 months ago

Thanks for raising this. I agree that we can integrate it into concurrently.

moritz-baecker-integra commented 6 days ago

Are you sure, that you want to include the functionality into concurrently? https://www.npmjs.com/package/spawn-command seems to be active, because the problem got fixed

PatrykKuniczak commented 4 days ago

@gustavohenke Are you able to realase this soon? I want to bump node to 22 on my project, but i don't want with this error :)

theonlypwner commented 2 days ago

mmalecki/spawn-command#9 was fixed, so that dependency wasn't actually unmaintained.

Instead of including its code in this repo, it would be easier to just bump spawn-command to 0.0.3 in package.json.