search

open-cluster-management-io / addon-framework

addon apis
Apache License 2.0
23 stars 40 forks source link

Update condition when call manifest failed #101

Closed qiujian16 closed 2 years ago

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/addon-framework/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
qiujian16 commented 2 years ago

fixes https://github.com/open-cluster-management-io/addon-framework/issues/98

zhujian7 commented 2 years ago

@qiujian16 The e2e failed, please take a look

qiujian16 commented 2 years ago

e2e is fixed.

zhujian7 commented 2 years ago

/lgtm