search

open-cluster-management-io / addon-framework

addon apis
Apache License 2.0
23 stars 40 forks source link

Support hosted mode #103

Closed zhujian7 closed 2 years ago

zhujian7 commented 2 years ago

Implementation https://github.com/open-cluster-management-io/enhancements/pull/65

TODO:

zhujian7 commented 2 years ago

@zhiweiyin318 @qiujian16 please help to review

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/addon-framework/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
qiujian16 commented 2 years ago

@zhujian7 i think we should squash the commit, then it is ok to merge as long as the enhancement one is merged.

qiujian16 commented 2 years ago

/lgtm

qiujian16 commented 2 years ago

/unhold