search

open-cluster-management-io / addon-framework

addon apis
Apache License 2.0
23 stars 40 forks source link

add pre-delete and hostedLocation annotation and will deprecate the labels #132

Closed zhiweiyin318 closed 1 year ago

zhiweiyin318 commented 2 years ago

Signed-off-by: Zhiwei Yin zyin@redhat.com

deprecate the pre-delete and hostedLocation label, and replace by the annotation. either the annotation or label can work in several release. if the value in the annotation is different from that in the label, use the value in the annotation. the label will be removed in the future release.

zhiweiyin318 commented 2 years ago

/assign @qiujian16 /assign @zhujian7 /assign @elgnay

qiujian16 commented 1 year ago

/approve /lgtm

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/addon-framework/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment