search

open-cluster-management-io / addon-framework

addon apis
Apache License 2.0
23 stars 40 forks source link

`AddOnDeloyment` is missing a `p` #134

Closed dhaiducek closed 1 year ago

dhaiducek commented 2 years ago

AddOnDeloyment --> AddOnDeployment

Affects:

Not sure the best route for handling this, but a deprecation note and having the misspelled function point to the new function might work? It's a minor thing, but I think fixing it is important.

qiujian16 commented 1 year ago

/assign @zhiweiyin318

zhiweiyin318 commented 1 year ago

fixed. /close

openshift-ci[bot] commented 1 year ago

@zhiweiyin318: Closing this issue.

In response to [this](https://github.com/open-cluster-management-io/addon-framework/issues/134#issuecomment-1438557188): >fixed. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.