search

open-cluster-management-io / addon-framework

addon apis
Apache License 2.0
23 stars 40 forks source link

only enable install strategy and update install progression when addon is managed by addon-manager #184

Closed haoqing0110 closed 1 year ago

haoqing0110 commented 1 year ago

This PR tried to fix: 1 When add-on cma is managed by self, cma defined install strategy should not work, since it has conflicted with hard code WithInstallStrategy(). 2 When add-on cma is managed by self, cma should not list installprogression in status.

haoqing0110 commented 1 year ago

/assign @qiujian16

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoqing0110, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/addon-framework/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
haoqing0110 commented 1 year ago

/hold

qiujian16 commented 1 year ago

/lgtm

qiujian16 commented 1 year ago

/unhold