open-cluster-management-io / addon-framework

addon apis
Apache License 2.0
23 stars 40 forks source link

Add a controller to support addon template #187

Closed zhujian7 closed 1 year ago

zhujian7 commented 1 year ago

implement for the proposal: https://github.com/open-cluster-management-io/enhancements/pull/87

zhujian7 commented 1 year ago

/cc @qiujian16 @haoqing0110 @zhiweiyin318

zhujian7 commented 1 year ago

@qiujian16 PTAL

zhujian7 commented 1 year ago

/cc @qiujian16 PTAL

openshift-ci[bot] commented 1 year ago

@zhujian7: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only open-cluster-management-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/open-cluster-management-io/addon-framework/pull/187#issuecomment-1597229320): >/cc @qiujian16 PTAL Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
zhujian7 commented 1 year ago

/hold

zhujian7 commented 1 year ago

/unhold

qiujian16 commented 1 year ago

/approve /lgtm /hold

@zhiweiyin318 @haoqing0110 Please also take a look

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/addon-framework/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
haoqing0110 commented 1 year ago

/lgtm

zhiweiyin318 commented 1 year ago

/unhold