search

open-cluster-management-io / addon-framework

addon apis
Apache License 2.0
23 stars 40 forks source link

Updating cluster management addon conflict #194

Closed zhujian7 closed 1 year ago

zhujian7 commented 1 year ago

version: 0.7.0

Running multiple addon managers using the addon-framework 0.7.0 in a hub cluster, the addon managers' log showed some errors:

# logs of the addon1

E0721 09:15:03.025319       1 base_controller.go:159] "management-addon-config-controller" controller failed to sync "addon2", err: clustermanagementaddons.addon.open-cluster-management.io "addon2" is forbidden: User "system:serviceaccount:multicluster-engine:addon1-sa" cannot patch resource "clustermanagementaddons/status" in API group "addon.open-cluster-management.io" at the cluster scope
# logs of the addon2

E0721 09:15:03.025319       1 base_controller.go:159] "management-addon-config-controller" controller failed to sync "addon1", err: clustermanagementaddons.addon.open-cluster-management.io "addon1" is forbidden: User "system:serviceaccount:multicluster-engine:addon2-sa" cannot patch resource "clustermanagementaddons/status" in API group "addon.open-cluster-management.io" at the cluster scope

From the logs, it seems that the management-addon-config-controller in the addon-manger is trying to update other clustermanagementaddons, so we need to filter the cma when running the management-addon-config-controller controller.

zhujian7 commented 1 year ago

/kind bug

openshift-ci[bot] commented 1 year ago

@zhujian7: The label(s) kind/bug cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/open-cluster-management-io/addon-framework/issues/194#issuecomment-1647436975): >/kind bug Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.