search

open-cluster-management-io / addon-framework

addon apis
Apache License 2.0
23 stars 40 forks source link

The agentdeploy controller cannot update the agent manifestWorks in time when the cluster is changed #198

Closed zhiweiyin318 closed 1 year ago

zhiweiyin318 commented 1 year ago

there are some cases the agent manifestworks have dependancies on the managed cluster, like the annotation or clusterClaim. but the agentdeploy controller only watches the addon and manifestwork, does not watch cluster, so cannot update manifestWorks in time when the cluster is changed.

zhiweiyin318 commented 1 year ago

cc @zhujian7

zhujian7 commented 1 year ago

It is not a good idea to watch the managed cluster for all addons, since it is easy to change, which may cause some performance issues. So we are going to provide a filter function that developers can use to filter which information the addon is interested in: https://github.com/open-cluster-management-io/addon-framework/pull/199