search

open-cluster-management-io / addon-framework

addon apis
Apache License 2.0
23 stars 40 forks source link

:bug: Skip health check for deployments whose replicas is 0 #215

Closed zhujian7 closed 1 year ago

zhujian7 commented 1 year ago

In some cases, we want to deploy a deployment resource whose replicas is 0 to the managed cluster, if we set the health probe type to "DeploymentAvailability", the addon can not become available since the readyReplicas is 0. In this situation, we want to make the health probe check pass for the addon.

qiujian16 commented 1 year ago

/approve /lgtm

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/addon-framework/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment