Add support to configure helm-agent-addon namespace.

[Imtiaz246]

Problem Statement:

• We are creating a helm-agent-addon using the installStrategy feature defined in the ClusterManagementAddon API. Currently we can't configure the namespace dynamically as per the ocm:issues:298 describes. In our use case, we need the ability to configure the namespace for the helm-agent-addon dynamically.
• Additionally, we want to leverage helm chart built-in values such as {{ Release.Namespace }} and {{ Release.Name }} to set the values of the helm-agent-addon.

Proposed Solution:

• We propose adding a feature/enhancement that allows for the dynamic configuration of the helm-agent-addon namespace. This would enable users to specify the namespace at build time through some configuration parameters.

Use Case Example:

• For example, in our use case, we want to set the helm-agent-addon namespace using the helm chart built-in value {{ Release.Namespace }} which would ensure consistency with the parent Helm release.

[zhujian7]

@Imtiaz246 thanks for reporting this

we can't configure the namespace dynamically as per the https://github.com/open-cluster-management-io/ocm/issues/298 describes.

PR https://github.com/open-cluster-management-io/addon-framework/pull/218 is trying to fix this.

additionally, we want to leverage helm chart built-in values such as {{ Release.Namespace }} and {{ Release.Name }}

there are 3 helm built-in values are supported, fortunately, {{ Release.Namespace }} and {{ Release.Name }} are included.

[zhujian7]

@Imtiaz246 I submitted a PR to support configuring the namespace for the helm addons, if you want you can try it with the latest addon-framework, example here

[Imtiaz246]

Great @zhujian7. Thank you for your quick response. Things are working as expected now.

[tamalsaha]

@zhujian7 , I think there is still one thing left to fix

https://github.com/open-cluster-management-io/addon-framework/blob/674dd8271a0870560a39829e189f56d13d7a6dd5/pkg/addonmanager/controllers/addoninstall/controller.go#L97-L113

addon.GetAgentAddonOptions().InstallStrategy.InstallNamespace is configured correctly

[tamalsaha]

There is also one more issue here. The ManagedClusterAddon crd defaults installNamespace to open-cluster-management-agent-addon.

https://github.com/open-cluster-management-io/api/blob/658739714f84467fa4e057c24d594fd6d416bed9/addon/v1alpha1/types_managedclusteraddon.go#L39

This causes problem because it does not take the correct installNamespace from the ClusterManagementAddon. https://github.com/open-cluster-management-io/ocm/blob/8a4c834ebf0f3c71ab9209572fb0b11cc942f5d5/pkg/addon/controllers/addonmanagement/addon_install_reconciler.go#L72

[qiujian16]

/assign @zhujian7

[zhujian7]

@tamalsaha we are going to deprecate the managedclusteraddon.spec.instllNamespace, if you want to make the ns configurable, I suggest you use the AgentInstallNamespace func to fully control the namespace value, for example, you can implement this func to read the value from the API addondeploymentconfig.spec.agentInstallNamespace, then any value changed in the field addondeploymentconfig.spec.agentInstallNamespace will be reflected on where the addon agent is installed.

[qiujian16]

/close

[openshift-ci[bot]]

@qiujian16: Closing this issue.

In response to [this](https://github.com/open-cluster-management-io/addon-framework/issues/217#issuecomment-2367121226): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.