search

open-cluster-management-io / addon-framework

addon apis
Apache License 2.0
23 stars 40 forks source link

✨ Support configuring install namespace for helm addon #218

Closed zhujian7 closed 10 months ago

zhujian7 commented 11 months ago

issue reference: https://github.com/open-cluster-management-io/addon-framework/issues/217

zhujian7 commented 11 months ago

/cc @qiujian16 @zhiweiyin318

qiujian16 commented 11 months ago

/approve

openshift-ci[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/addon-framework/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
qiujian16 commented 11 months ago

leave to @zhiweiyin318 for final review

zhiweiyin318 commented 10 months ago

/lgtm