search

open-cluster-management-io / addon-framework

addon apis
Apache License 2.0
23 stars 40 forks source link

IndexManifestWorkByAddon ? #222

Open tamalsaha opened 1 year ago

tamalsaha commented 1 year ago

https://github.com/open-cluster-management-io/addon-framework/blob/51742bc299f22d1d290189455ac8a6fa9594f10c/pkg/index/index.go#L135

if len(addonName) == 0 || len(addonNamespace) > 0 || isHook {
        return []string{}, nil
    }

Should len(addonNamespace) > 0 be len(addonNamespace) == 0 ?

qiujian16 commented 8 months ago

cc @zhiweiyin318

zhiweiyin318 commented 8 months ago

@tamalsaha IndexManifestWorkByAddon is only to filter default mode addon manifestworks. addonNamespace is got from label, that means the addon is hosted mode if addonNamespace is not empty. we need comments for understanding here.